Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editoast: fix authz for search endpoint operationalpoint #11050

Merged
merged 1 commit into from
Mar 10, 2025
Merged

editoast: fix authz for search endpoint operationalpoint #11050

merged 1 commit into from
Mar 10, 2025

Conversation

flomonster
Copy link
Contributor

No description provided.

@flomonster flomonster requested a review from a team as a code owner March 6, 2025 14:58
@github-actions github-actions bot added the area:editoast Work on Editoast Service label Mar 6, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2025 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.66%. Comparing base (8590f5e) to head (a78d997).
Report is 12 commits behind head on dev.

Files with missing lines Patch % Lines
editoast/src/views/search.rs 75.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev   #11050      +/-   ##
==========================================
+ Coverage   80.63%   80.66%   +0.03%     
==========================================
  Files        1101     1101              
  Lines      112338   112489     +151     
  Branches      747      747              
==========================================
+ Hits        90580    90744     +164     
+ Misses      21715    21702      -13     
  Partials       43       43
Flag Coverage Δ
editoast 72.36% <75.00%> (+0.16%) ⬆️
front 89.92% <ø> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 2.53% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 87.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

leovalais
leovalais approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops

@flomonster flomonster enabled auto-merge March 10, 2025 08:45
@flomonster flomonster added this pull request to the merge queue Mar 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 10, 2025
@leovalais leovalais added this pull request to the merge queue Mar 10, 2025
Merged via the queue into dev with commit 2f4b391 Mar 10, 2025
27 checks passed
@leovalais leovalais deleted the fam/fix-perm branch March 10, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woshilapin woshilapin woshilapin approved these changes

@leovalais leovalais leovalais approved these changes

Assignees
No one assigned
Labels
area:editoast Work on Editoast Service
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flomonster @codecov-commenter @woshilapin @leovalais